Skip to content

Update Data Browser html file - #567

Merged
dmitrizagidulin merged 1 commit into
dz_oidcfrom
update-data-browser
Sep 1, 2017
Merged

Update Data Browser html file#567
dmitrizagidulin merged 1 commit into
dz_oidcfrom
update-data-browser

Conversation

@dmitrizagidulin

@dmitrizagidulin dmitrizagidulin commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

To use the new auth client.

RubenVerborgh
RubenVerborgh reviewed Aug 31, 2017
View reviewed changes
Comment thread config/defaults.js
'serverUri': 'https://localhost:8443',
'webid': true
'webid': true,
'dataBrowserPath': 'default'

@RubenVerborgh RubenVerborgh Aug 31, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are possible alternative values? Why isn't this static/databrowser.html?

@dmitrizagidulin dmitrizagidulin Aug 31, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure why it was done this way. I do know that it's what activates it.

@RubenVerborgh

RubenVerborgh commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

Any steps to test?

@dmitrizagidulin

dmitrizagidulin commented Aug 31, 2017

Copy link
Copy Markdown
Contributor Author

To test, start up the server and request some rdf file on the server, say /settings/prefs.ttl or something. (Test on a browser that doesn't have an rdf plugin)

@RubenVerborgh

RubenVerborgh commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

I get Uncaught ReferenceError: Mashlib is not defined.

@dmitrizagidulin

dmitrizagidulin commented Aug 31, 2017

Copy link
Copy Markdown
Contributor Author

Ah damn, I think I forgot a git push

@dmitrizagidulin

dmitrizagidulin commented Aug 31, 2017

Copy link
Copy Markdown
Contributor Author

Maybe there's a delay in propagation to github.io..

@RubenVerborgh

RubenVerborgh commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

No change unfortunately.

@dmitrizagidulin

dmitrizagidulin commented Sep 1, 2017

Copy link
Copy Markdown
Contributor Author

Found the issue - mashlib repo was still set to serve gh-pages instead of master on github.io. Should be fixed shortly..

@dmitrizagidulin

dmitrizagidulin commented Sep 1, 2017

Copy link
Copy Markdown
Contributor Author

(might require a shift-refresh)

@RubenVerborgh RubenVerborgh added this to the 4.0.0 milestone Sep 1, 2017
@RubenVerborgh

RubenVerborgh commented Sep 1, 2017

Copy link
Copy Markdown
Contributor

(BTW regarding gh-pages and master, see linkeddata/rdflib.js#201.)

@RubenVerborgh RubenVerborgh mentioned this pull request Sep 1, 2017
Closed
RubenVerborgh
RubenVerborgh approved these changes Sep 1, 2017
View reviewed changes

@RubenVerborgh RubenVerborgh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@dmitrizagidulin
dmitrizagidulin merged commit 928ff50 into dz_oidc Sep 1, 2017
@dmitrizagidulin
dmitrizagidulin deleted the update-data-browser branch September 1, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timbl timbl Awaiting requested review from timbl
1 more reviewer
@RubenVerborgh RubenVerborgh RubenVerborgh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitrizagidulin @RubenVerborgh