Skip to content

lookup: remove weak - #1187

Merged
BethGriggs merged 1 commit into
nodejs:mainfrom
MikeMcC399:remove/weak
Oct 12, 2026
Merged

BethGriggs merged 1 commit into
nodejs:mainfrom
MikeMcC399:remove/weak

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

Running citgm weak passes only on a subset of variants.
macos - passes all
ubuntu - fails on Node.js 24 & 26 with a native stack trace
windows - fails on all Node.js release lines with node.gyp errors

The repo https://github.com/TooTallNate/node-weak is unmaintained and the last release weak@1.0.1 was more than 10 years ago on Jan 4, 2016.

Change

Remove weak from the lookup.json table.

Also remove it from test-lookup.js, where it serves as an example for a maintainer entry. Use undici as an example instead.

Checklist
  • npm test passes
  • contribution guidelines followed
    here

cc: @TooTallNate

Use undici for testing of maintainer entry

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (17e7dea) to head (309a546).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1187   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BethGriggs BethGriggs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm download numbers are also pretty low so not losing a significant amount of ecosystem testing.

@BethGriggs
BethGriggs merged commit eeb7a8b into nodejs:main Oct 12, 2026
11 checks passed
@MikeMcC399
MikeMcC399 deleted the remove/weak branch October 12, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weak fails on Node.js 24 & 26 (ubuntu) & Node.js 24-26 (windows)

4 participants