Repository navigation
Unchecked sqlite3 API calls #63311
Description
Version
v25.6.0
Platform
Linux 749dbb0e74fd 6.8.0-106-generic #106-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 6 07:58:08 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
sqlite
What steps will reproduce the bug?
There are some inconsistencies in how the sqlite3_reset API is checked.
All places where it is called via StatementSync::ResetStatement() are checked. For example:
Lines 3092 to 3093 in bf7e79c
or some others not via ResetStatement():
Lines 3353 to 3354 in bf7e79c
etc...
However, the following locations are not checked and should probably get exception checking as well:
Line 2972 in bf7e79c
Line 3026 in bf7e79c
Line 3473 in bf7e79c
Line 3705 in bf7e79c
Line 3757 in bf7e79c
Similarly, sqlite3_step() is normally checked for errors, but not here:
Line 2896 in bf7e79c
I could provide patches if this is a confirmed bug and the fix is desired.
How often does it reproduce? Is there a required condition?
Only reproduces if there's an internal libsqlite3 failure.
What is the expected behavior? Why is that the expected behavior?
I would expect consistent checking and throwing of exceptions.
What do you see instead?
Failure is ignored silently.
Additional information
This was detected with the help of a static-dynamic hybrid analyzer I'm developing.
Activity
sqlite: check sqlite3_step() and sqlite3_reset() results
sqlite: check sqlite3_step() and sqlite3_reset() results
sqlite: check sqlite3_step() and sqlite3_reset() results