n-api: port test for make_callback

[digitalinfinity]

Improved test coverage for napi_make_callback by porting the
existing addons/make_callback test to napi

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

Affected core subsystem(s)

n-api, test

[digitalinfinity]

cc @nodejs/n-api

FYI, @jasongin - noticed that one of the existing node::makeCallback tests was failing- I've commented that test case out in this test, and we can track that with a separate issue

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/7395/

[digitalinfinity]

Thanks @vsemozhetbyt - pushed a quick commit to fix the typo that caused the CI break - I haven't had a chance to fully retest after the latest commit, but I'll try that in the morning. Apologies for the break 😞

[vsemozhetbyt]

CI: https://ci.nodejs.org/job/node-test-pull-request/7396/

[addaleax]

This looks good to me, but it’s probably worth mentioning that this doesn’t seem to test the relevant use case for MakeCallback, i.e. entering JS from a async worker’s complete callback without any pre-existing JS stack.

That’s probably best kept for another PR, but something like that should be added.

[addaleax]

Why args[1] instead of func?

[digitalinfinity]

oversight - I'll change (initially everything was args[blah] but I refactored to use locals but missed updating this reference)

[addaleax]

Oh, also: For test-only changes we prefer to use test: instead of another subsystem label, that makes it easier to filter out the actual behavioural changes in our changelogs, it would be good if you could update that here

[digitalinfinity]

Thanks @addaleax @benjamingr for reviewing. @addaleax I can rewrite the commit title- is that what you meant, or did you mean I should update the PR title?

[addaleax]

@digitalinfinity Yes, updating the commit message would be good (you can squash the commits together at the same time, if you like). Or we just hope the person landing these changes doesn’t overlook these comments. 😄

[digitalinfinity]

Thanks @addaleax - rebased and squashed.

[jasnell]

Landed in 70b51c8

[jasnell]

opened a PR to revert this. It's broken on windows.

[jasnell]

Post mortem on having to revert this: I had seen the CI failure on windows but had moved this to the wrong list when I was organizing the set of PRs to land and which needed more time. Since the CI failure only shows on Windows, it didn't show up when I ran make test locally on Ubuntu before landing. The Windows CI failure needs to be looked at then it can be landed again.

[mhdawson]

@digitalinfinity this is waiting for fixup due to the ci failures.

[addaleax]

New CI because the old one is inaccessible: https://ci.nodejs.org/job/node-test-commit/9514/

[addaleax]

CI looks really good – I can’t see the old failures anymore, maybe this has been fixed as part of other changes? Can somebody from @nodejs/platform-windows check that this works fine now?

[refack]

I started a build.
Can anyone tell me what to look for? What were the previous failures?

[refack]

D:\code\node-cur\test\addons-napi\test_make_callback$ d:\code\node-cur\Debug\node.exe --napi-modules test.js
MyFunc was called with 3 arguments
(node:2820) Warning: N-API is an experimental feature and could change at any time.

D:\code\node-cur\test\addons-napi\test_make_callback$ echo %ERRORLEVEL%
0

and

D:\code\node-cur\test\addons-napi\test_make_callback_recurse$ d:\code\node-cur\Debug\node.exe --napi-modules test.js
(node:10872) Warning: N-API is an experimental feature and could change at any time.

D:\code\node-cur\test\addons-napi\test_make_callback_recurse$ echo %ERRORLEVEL%
0

[digitalinfinity]

Whoops, my bad y'all, I missed that this guy hadn't landed yet- I'll fix the lint error and update

[digitalinfinity]

Ok, rebased and fixed the lint error- can someone help trigger a CI run please for sanity?

[refack]

New CI: https://ci.nodejs.org/job/node-test-commit/9652/
Good luck 🤞

[digitalinfinity]

gah- it fails on the older version of the compiler for windows- i'll update the PR

[digitalinfinity]

Updated the PR to use const instead of constexpr- @nodejs/platform-windows what is the support story for compilers on Windows. The failing case was VS2015, but AFAIK VS2015 has supported constexpr since at least VS2015 Update 1. Do we support older compilers or does Jenkins need to be updated?

[kunalspathak]

New CI - https://ci.nodejs.org/job/node-test-pull-request/7904/
https://ci.nodejs.org/job/node-test-pull-request/7905/

[seishun]

It seems CI is accidentally using the wrong VS version to build the addons, since 12.0 is VS2013 (which is not supported for building Node.js).

[refack]

Ping @nodejs/build is win2008r2/vs2015 purposefully using Visual Studio 2015 without Update 1?

[digitalinfinity]

Independent of the CI configuration, it looks like the CI for the latest commit passed- thanks @kunalspathak for triggering the CI

[refack]

@jasnell / @addaleax can I land this?

[addaleax]

@refack I think so, yes

[refack]

Landed in 73d9c0f

[refack]

Post land CI: https://ci.nodejs.org/job/node-test-commit/9698/

[joaocgreis]

A note about our CI configuration: All Windows 2008 machines run VS2013, since for building native modules VS2013 is still supported. So, the node-compile-windows job does not run on VS2013 for recent versions, but the node-test-binary-windows job will run the addons tests with VS2013 on the configurations that run in Windows 2008.