Skip to content

benchmark: fix http/bench-parser.js#27360

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:fix-http-benchmark
Closed

benchmark: fix http/bench-parser.js#27360
refack wants to merge 1 commit into
nodejs:masterfrom
refack:fix-http-benchmark

Conversation

@refack

@refack refack commented Apr 23, 2019

Copy link
Copy Markdown
Contributor

Follow up for #25094

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Apr 23, 2019
@refack refack requested review from Trott and mmarchini April 23, 2019 13:00
@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 72 hours to land. labels Apr 23, 2019
@refack

refack commented Apr 23, 2019

Copy link
Copy Markdown
Contributor Author

This fixes a failing test in the benchmark suite, so I suggest we fast track this.
Please πŸ‘ if you concur.

@Flarna

Flarna commented Apr 23, 2019

Copy link
Copy Markdown
Member

dup to #27359?

@refack

refack commented Apr 23, 2019

Copy link
Copy Markdown
Contributor Author

Closed as dup

@refack refack closed this Apr 23, 2019
@refack refack added abandoned and removed flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 72 hours to land. labels Apr 23, 2019
@refack refack deleted the fix-http-benchmark branch April 23, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants