Skip to content

fs: fix broken esm#28957

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:fix-esm
Closed

fs: fix broken esm#28957
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:fix-esm

Conversation

@ronag

@ronag ronag commented Aug 4, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Tries to fix blocked CITGM. See, standard-things/esm#821.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Aug 4, 2019
@ronag

ronag commented Aug 4, 2019

Copy link
Copy Markdown
Member Author

@Trott: can I get a CITGM on this one?

@ronag ronag changed the title utils: fix broken esm fs: fix broken esm Aug 4, 2019
@ronag

ronag commented Aug 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

@benjamingr can you start a CITGM on this one? ping @Trott

@mcollina

mcollina commented Aug 6, 2019

Copy link
Copy Markdown
Member

cc @jdalton wdyt?

@mcollina mcollina requested a review from joyeecheung August 6, 2019 10:48
@jdalton

jdalton commented Aug 6, 2019

Copy link
Copy Markdown
Member

LGTM as a workaround until a fix can be published.

@BridgeAR

BridgeAR commented Aug 6, 2019

Copy link
Copy Markdown
Member

@jdalton did your recent change in esm not fix the issue?

BridgeAR
BridgeAR approved these changes Aug 6, 2019
View reviewed changes

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as intermediate fix. This should definitely be removed as soon as possible though.

Comment thread lib/internal/fs/utils.js Outdated
@Trott

Trott commented Aug 6, 2019

Copy link
Copy Markdown
Member

@mcollina Looks good to you as a temporary measure?

@nodejs-github-bot

nodejs-github-bot commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24860/

@Trott

Trott commented Aug 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@Trott: can I get a CITGM on this one?

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1923/

mcollina
mcollina approved these changes Aug 6, 2019
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CITGM passes.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 6, 2019
trivikr
trivikr approved these changes Aug 6, 2019
View reviewed changes

@trivikr trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit

Comment thread lib/internal/fs/utils.js
Object.setPrototypeOf(Stats.prototype, StatsBase.prototype);
Object.setPrototypeOf(Stats, StatsBase);

// HACK: Workaround for https://github.com/standard-things/esm/issues/821.

@trivikr trivikr Aug 6, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: period becomes part of link

Suggested change
// HACK: Workaround for https://github.com/standard-things/esm/issues/821.
// HACK: Workaround for https://github.com/standard-things/esm/issues/821

@nodejs-github-bot

nodejs-github-bot commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24869/

@Trott

Trott commented Aug 6, 2019

Copy link
Copy Markdown
Member

CITGM this PR: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1923/

CITGM against master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1925/

@Trott

Trott commented Aug 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

CITGM master: 84 failures

CITM this PR: 29 failures

CI is green

This has two TSC approvals (necessary for semver-major)

Landing.

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 7, 2019
@ronag @Trott
fs: fix (temporary) for esm package
320402c 
Fix to unblock CITGM. See,
standard-things/esm#821.

PR-URL: nodejs#28957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

Trott commented Aug 7, 2019

Copy link
Copy Markdown
Member

(@joyeecheung If you have an issue with this, we can revert it, of course.)

@Trott

Trott commented Aug 7, 2019

Copy link
Copy Markdown
Member

Landed in 320402c

@Trott Trott closed this Aug 7, 2019
@joyeecheung

joyeecheung commented Aug 7, 2019

Copy link
Copy Markdown
Member

Belated LGTM and thanks for the ping!

@targos

targos commented Aug 19, 2019

Copy link
Copy Markdown
Member

Backport blocked by #21387

BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@ronag @BridgeAR
fs: fix (temporary) for esm package
6ff803d 
Fix to unblock CITGM. See,
standard-things/esm#821.

PR-URL: #28957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
@Trott Trott mentioned this pull request Oct 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ronag @mcollina @jdalton @BridgeAR @Trott @nodejs-github-bot @joyeecheung @targos @trivikr