doc: the method readable.push description#29687
Closed
ImHype wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
doc
ImHype
changed the title
readable.push description
Contributor
Author
ImHype
force-pushed
the
doc_29680
branch
6 times, most recently
from
c3d30c8 to
65eb07e
Compare
|
This is a clearer description. |
Trott
reviewed
Sep 25, 2019
Member
|
@nodejs/streams @nodejs/documentation |
jasnell
approved these changes
Sep 25, 2019
jasnell
left a comment
jasnell
left a comment
Member
There was a problem hiding this comment.
Just a nit: lines need to be wrapped at <= 80 chars
Contributor
Author
|
Fine, I got it. Thanks for your approve. |
Member
BethGriggs
approved these changes
Sep 27, 2019
trivikr
approved these changes
Sep 27, 2019
Member
trivikr
added
the
author ready
Member
|
Landed in 63c0f15 |
Trott
pushed a commit
that referenced
this pull request
Sep 27, 2019
PR-URL: #29687 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 1, 2019
PR-URL: #29687 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes