Skip to content

[v16.x backport] stream: implement streams to webstreams adapters#40384

Closed
Mesteery wants to merge 1 commit into
nodejs:v16.x-stagingfrom
Mesteery:backport-39134-to-v16.x
Closed

[v16.x backport] stream: implement streams to webstreams adapters#40384
Mesteery wants to merge 1 commit into
nodejs:v16.x-stagingfrom
Mesteery:backport-39134-to-v16.x

Conversation

@Mesteery

@Mesteery Mesteery commented Oct 9, 2021

Copy link
Copy Markdown
Contributor

Backport of #39134.

Experimental adapters for the webstreams API

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#39134
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Oct 9, 2021

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2021
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@targos

targos commented Oct 9, 2021

Copy link
Copy Markdown
Member
node:internal/process/promises:246
          triggerUncaughtException(err, true /* fromPromise */);
          ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   code: 'ERR_STREAM_PREMATURE_CLOSE'
-   code: 'ABORT_ERR'
  }
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close
      at new NodeError (node:internal/errors:371:5)
      at PassThrough.onclose (node:internal/streams/end-of-stream:135:30)
      at PassThrough.emit (node:events:402:35)
      at emitCloseNT (node:internal/streams/destroy:138:10)
      at processTicksAndRejections (node:internal/process/task_queues:82:21) {
    code: 'ERR_STREAM_PREMATURE_CLOSE'
  },
  expected: { code: 'ABORT_ERR' },
  operator: 'rejects'
}

/cc @nodejs/streams @jasnell

@Mesteery

Mesteery commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

also

Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
    at Proxy.mustCall (/home/iojs/build/workspace/node-test-commit-linux/test/common/index.js:352:10)
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-whatwg-webstreams-adapters-to-readablestream.js:34:31)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos

targos commented Oct 9, 2021

Copy link
Copy Markdown
Member

I was more asking for help, since there are a lot of failing tests (probably because parts of this depend on a semver-major change)

@Mesteery

Mesteery commented Oct 9, 2021

Copy link
Copy Markdown
Contributor Author

I was more asking for help, since there are a lot of failing tests (probably because parts of this depend on a semver-major change)

Since, indeed, it depends on a semver-major (#38505). It is not possible to backport the PR to 16.x release line, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants