Repository navigation
Conversation
nodejs-github-bot
added
needs-ci
mcollina
force-pushed
the
process-finalization-unregister-fn
branch
from
October 3, 2026 14:33
cbf147f to
e214630
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66482 +/- ##
=======================================
Coverage 90.47% 90.47%
=======================================
Files 791 791
Lines 277088 277101 +13
Branches 53276 53276
=======================================
+ Hits 250686 250707 +21
+ Misses 16813 16802 -11
- Partials 9589 9592 +3
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Oct 5, 2026
mcollina
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
mcollina
added
the
commit-queue
nodejs-github-bot
added
lacks-second-approval
Collaborator
Commit Queue failedThe pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
process.finalization.register() and registerBeforeExit() now return a function that removes only that registration, leaving other registrations for the same object in place. The function does not hold a strong reference to the object. Each registration now uses its WeakRef as the unregister token, which also makes process.finalization.unregister() remove the entries from the FinalizationRegistry; previously it passed the object as the token, which was never registered, so the call had no effect. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed
The pull request was removed from the Commit Queue and labeled
commit-queue-failed
Full Commit Queue output |
mcollina
force-pushed
the
process-finalization-unregister-fn
branch
from
October 12, 2026 11:12
e214630 to
4a67914
Compare
ShogunPanda
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process.finalization.register()andprocess.finalization.registerBeforeExit()now return a function that removes that specific registration:Other registrations for the same object are left in place, calling the function more than once is a no-op, and the function does not hold a strong reference to
obj.Each registration now uses its
WeakRefas theFinalizationRegistryunregister token. This also fixesprocess.finalization.unregister(obj), which calledregistry.unregister(obj)althoughobjwas never passed as a token, so the registry entries were never removed.AI generated. Reviewed by me.