Repository navigation
Conversation
decodeFormComponent() already finds the first percent character, but hasPercentHex() scans the plain prefix again. Start the check at the known position to avoid repeating that work. Replacing plus signs with spaces preserves character positions, so escape validation and decoding behavior remain unchanged. Signed-off-by: Roberto Bianchi <roberto.bianchi@spendesk.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66696 +/- ##
==========================================
- Coverage 90.47% 90.47% -0.01%
==========================================
Files 791 791
Lines 277088 277088
Branches 53286 53281 -5
==========================================
- Hits 250703 250696 -7
+ Misses 16805 16803 -2
- Partials 9580 9589 +9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodeFormComponent()already locates the first%, buthasPercentHex()scans from the beginning again. Pass that position to the helper so it skips the plain-text prefix. Replacing+with a space preserves the position; escape validation and decoding behavior are unchanged.Constructor throughput on Apple M2/macOS, with rebuilt Node v27.0.0-pre binaries
against upstream
a7a96c2448ab91ca079de5e64233aa79a400b00e:%20%20%E2%82%ACNo corrected-significant regressions were detected.