Skip to content

build,test: enable temporal support on no-ICU and system-ICU builds - #66697

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:temporal-shared-no-icu
Oct 13, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:temporal-shared-no-icu

Conversation

@aduh95

@aduh95 aduh95 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Refs: #65992
Refs: #66183

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 13, 2026

@sxa sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding @richardlau as reviewer since he put the comment in and is also preparing the current 26 release :-)

@sxa
sxa requested a review from richardlau October 13, 2026 09:01
@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.49%. Comparing base (c883ccf) to head (3b79e5e).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66697      +/-   ##
==========================================
- Coverage   92.82%   90.49%   -2.34%     
==========================================
  Files         422      791     +369     
  Lines      194189   277088   +82899     
  Branches    30039    53281   +23242     
==========================================
+ Hits       180257   250737   +70480     
- Misses      13607    16759    +3152     
- Partials      325     9592    +9267     

see 499 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau richardlau added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau

Copy link
Copy Markdown
Member

I'll stick a fast-track label on this. If we can get a clean CI on this today in the next few (say three) hours then I'll pull it into #66684.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau richardlau added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 13, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 13, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✖  GitHub CI is still running
   ✖  Last Jenkins CI still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output
�[36m⠋�[39m Loading data for nodejs/node/pull/66697
�[36m⠋�[39m Loading data for nodejs/node/pull/66697
�[36m⠋�[39m Getting collaborator contacts from README of nodejs/node
�[36m⠋�[39m Getting PR from nodejs/node/pull/66697
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66697
�[36m⠋�[39m Getting comments from nodejs/node/pull/66697
�[36m⠋�[39m Getting commits from nodejs/node/pull/66697
✔  Done loading data for nodejs/node/pull/66697
----------------------------------- PR info ------------------------------------
Title      build,test: enable temporal support on no-ICU and system-ICU builds (#66697)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:temporal-shared-no-icu -> nodejs:main
Labels     build, fast-track, needs-ci, commit-queue
Commits    1
 - build,test: enable temporal support on no-ICU and system-ICU builds
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66697
Refs: https://github.com/nodejs/node/pull/65992
Refs: https://github.com/nodejs/node/pull/66183
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/66697
Refs: https://github.com/nodejs/node/pull/65992
Refs: https://github.com/nodejs/node/pull/66183
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 13 Oct 2026 07:16:19 GMT
   ✔  Approvals: 2
   ✔  - Stewart X Addison (@sxa): https://github.com/nodejs/node/pull/66697#pullrequestreview-5501167285
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/66697#pullrequestreview-5502759044
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-10-13T13:56:24Z: https://ci.nodejs.org/job/node-test-pull-request/78373/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78373/
�[36m⠙�[39m Querying data for job/node-test-pull-request/78373/
�[36m⠙�[39m Querying API for job/node-test-pull-request/78373/
✔  Build data downloaded
   ✖  Last Jenkins CI still running
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 13, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ea6ec93 into nodejs:main Oct 13, 2026
101 of 102 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in ea6ec93

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 13, 2026
richardlau pushed a commit that referenced this pull request Oct 13, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #66697
Refs: #65992
Refs: #66183
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants