Skip to content

deps: V8: cherry-pick 99f317d69ac7 - #66700

Open
shipujin wants to merge 1 commit into
nodejs:mainfrom
shipujin:fix-build-loong64
Open

shipujin wants to merge 1 commit into
nodejs:mainfrom
shipujin:fix-build-loong64

Conversation

@shipujin

@shipujin shipujin commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Compilation error:

CXX(target) /build-node/out/Release/obj.target/v8_base_without_compiler/gen/inspector-generated-output-root/src/inspector/protocol/Schema.o
rm -f /build-node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a ar-file-list; mkdir -p `dirname /build-node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a`
ar crsT /build-node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a @/build-node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a.ar-file-list
  TOUCH /build-node/out/Release/obj.target/tools/v8_gypfiles/torque_generated_initializers.stamp
  LINK(target) /build-node/out/Release/mksnapshot
/usr/bin/ld: /build-node/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/instruction-selector.o: in function `.L4121':
instruction-selector.cc:(.text._ZN2v88internal8compiler19InstructionSelector9VisitNodeENS1_10turboshaft7OpIndexE+0xcec): undefined reference to `v8::internal::compiler::InstructionSelector::VisitUint64Add3WithCarry(v8::internal::compiler::turboshaft::OpIndex)'
collect2: error: ld returned 1 exit status
make[1]: *** [tools/v8_gypfiles/mksnapshot.target.mk:257: /build-node/out/Release/mksnapshot] Error 1

The upstream fix patch is: https://chromium-review.googlesource.com/c/v8/v8/+/8416173

Original commit message:

[loong64][mips64][wasm-wide-arith] optimize nested 128 bit additions

Bug: 491766259
Change-Id: Iccf2ae0979844440b14452e1f6de7e12fb0cf7da
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8416173
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Auto-Submit: Liu Yu <liuyu@loongson.cn>
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#109857}

Refs: v8/v8@99f317d

Original commit message:

    [loong64][mips64][wasm-wide-arith] optimize nested 128 bit additions

    Bug: 491766259
    Change-Id: Iccf2ae0979844440b14452e1f6de7e12fb0cf7da
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8416173
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Auto-Submit: Liu Yu <liuyu@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Cr-Commit-Position: refs/heads/main@{#109857}
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 13, 2026
@aduh95

aduh95 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

This is already in #66601, should we close this or are you trying to get this on some release lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants