Skip to content

Revert "sea: mount vfsArchive at layer 0 and in workers" - #66706

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:revert-66614
Oct 13, 2026
Merged

aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:revert-66614

Conversation

@aduh95

@aduh95 aduh95 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

@aduh95 aduh95 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/single-executable

@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Oct 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@pipobscure

Copy link
Copy Markdown
Contributor

Please revert, I’ll look at what the actual issue is, as I could not reproduce on Linux/Windows in my local run.

@aduh95

aduh95 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

The worker job (which was the only one seeing the failure) has succeeded, merging without waiting for the other jobs

@aduh95
aduh95 merged commit 3f0c2e4 into nodejs:main Oct 13, 2026
53 of 78 checks passed
@aduh95

aduh95 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Landed in 3f0c2e4

@aduh95
aduh95 deleted the revert-66614 branch October 13, 2026 13:48
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.48%. Comparing base (a67d2a8) to head (b2281aa).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea.cc 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66706   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files         791      791           
  Lines      277245   277196   -49     
  Branches    53318    53305   -13     
=======================================
- Hits       250858   250816   -42     
+ Misses      16799    16796    -3     
+ Partials     9588     9584    -4     
Files with missing lines Coverage Δ
lib/internal/main/embedding.js 91.89% <100.00%> (+0.08%) ⬆️
lib/internal/main/worker_thread.js 95.02% <ø> (-0.05%) ⬇️
lib/internal/vfs/sea.js 100.00% <100.00%> (ø)
src/node_options.cc 81.70% <ø> (+<0.01%) ⬆️
src/node_sea.h 100.00% <ø> (ø)
src/node_sea.cc 87.87% <83.33%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallel/test-bootstrap-modules broken in workers CI

8 participants