Skip to content

Add version toggle to download page#357

Merged
rnsloan merged 4 commits into
nodejs:masterfrom
rnsloan:download-version-toggle
Nov 17, 2015
Merged

Add version toggle to download page#357
rnsloan merged 4 commits into
nodejs:masterfrom
rnsloan:download-version-toggle

Conversation

@rnsloan

@rnsloan rnsloan commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

Fixes #321

  • Add toggle
  • remove top-right menu

1


2


3

@fhemberger

Copy link
Copy Markdown
Contributor

Wow, awesome! 👍

@bnb

bnb commented Nov 13, 2015

Copy link
Copy Markdown
Contributor

Rally rad! 👍

@lpinca

lpinca commented Nov 13, 2015

Copy link
Copy Markdown
Member

It looks great.

@phillipj

Copy link
Copy Markdown
Member

+:100:

@stevemao

Copy link
Copy Markdown
Contributor

The images look awesome :) has anyone else tested this yet?

@diagramatics

Copy link
Copy Markdown
Contributor

How about a different active color for LTS and stable, just to indicate which version the user is going to download easier?

@bnb

bnb commented Nov 14, 2015

Copy link
Copy Markdown
Contributor

@diagramatics I was looking at the gif, and noticed that the Windows/OS X/Source parts have a dark gray background on hover. Maybe that could be used?

@rnsloan

rnsloan commented Nov 16, 2015

Copy link
Copy Markdown
Contributor Author

@bnb like this?

full

black

@bnb

bnb commented Nov 16, 2015

Copy link
Copy Markdown
Contributor

@rnsloan Yes, except keep the bright green (from the previous version) for the active state.

Notice how the gray background is only visible on hover for the Windows/Mac/Source buttons. Like that, except with the green background as an active state.

@rnsloan

rnsloan commented Nov 17, 2015

Copy link
Copy Markdown
Contributor Author

Colors updated. Merging.

rnsloan added a commit that referenced this pull request Nov 17, 2015
Add version toggle to download page
@rnsloan rnsloan merged commit 2b1ac04 into nodejs:master Nov 17, 2015
@phillipj

Copy link
Copy Markdown
Member

👯 nice work!

@bnb

bnb commented Nov 17, 2015

Copy link
Copy Markdown
Contributor

Good job. Looks awesome live!

@stevemao

Copy link
Copy Markdown
Contributor

Perfect, Thanks @rnsloan :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants