Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mcollina
force-pushed
the
doc/windows-archive-permissions
branch
from
November 4, 2026 14:09
70ddebe to
8da1bb5
Compare
Member
Author
|
I need a better design for this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9312 +/- ##
==========================================
- Coverage 86.97% 86.89% -0.08%
==========================================
Files 88 88
Lines 6356 6356
Branches 386 387 +1
==========================================
- Hits 5528 5523 -5
- Misses 824 829 +5
Partials 4 4 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the Windows installation security guidance update across the three English download pages.
No open issues 🎉
What changed in this PR
Adds Windows installation security guidance to all three English download pages, helping users avoid unsafe permissions for system-wide Node.js installations.
Changes:
- Recommends the Windows Installer (
.msi) for system-wide installations when possible. - Warns users installing from
.zipor.7zarchives to prevent untrusted users from creating or modifying installation files. - Places the same note immediately after the signed SHASUMS verification guidance on each page.
| File | Description |
|---|---|
apps/site/pages/en/download/index.mdx |
Adds Windows installation permissions guidance to the main download page. |
apps/site/pages/en/download/current.mdx |
Adds the same guidance to the current download page. |
apps/site/pages/en/download/alpha.mdx |
Adds the same guidance to the alpha download page. |
Review effort: Balanced
Contributor
📦 Build Size ComparisonSummary
|
avivkeller
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Windows-specific note to the download pages. The note recommends using the Windows Installer for system-wide installations and warns users who install from
.zipor.7zarchives to extract Node.js to a directory that is not writable by untrusted users.The note is added to
apps/site/pages/en/download/{index,current,alpha}.mdx, right after the "verify signed SHASUMS" line.Validation
prettier --checkandeslinton the changed fileslint:types(pre-commit hook)Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.