Skip to content

draft blog for publish baseline practices guide - #243

Merged
Eomm merged 23 commits into
nodejs:masterfrom
jchip:master
Oct 12, 2019
Merged

Eomm merged 23 commits into
nodejs:masterfrom
jchip:master

Conversation

@jchip

@jchip jchip commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

blog for #164

Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved

@ghinks ghinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I @jchip & @ljharb I have gone over the suggestions made by @ljharb to this PR and I want to give them my thumbs up.

I only have one item that we can address elsewhere. Even after watching the video and reading the tink repo I'm not completely convinced tink addresses all the issues. It does solve the size problem as it essentially caches but I did not see the fine level of installation that would mean being able to choose the functional part of a package without things such as tests.

jchip and others added 7 commits August 29, 2019 08:25
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@jchip
jchip requested review from ghinks, lholmquist and ljharb August 29, 2019 16:05
@ljharb

ljharb commented Aug 29, 2019

Copy link
Copy Markdown
Member

@ghinks with tink, nothing is installed until the first time you require/import it - it's downloaded on demand. In other words, the default disk size for every package is zero.

Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
jchip and others added 7 commits September 10, 2019 06:22
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Co-Authored-By: Manuel Spigolon <behemoth89@gmail.com>
Co-Authored-By: Manuel Spigolon <behemoth89@gmail.com>

@ghinks ghinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change allowing both ways without prejudice

@ljharb

ljharb commented Sep 14, 2019

Copy link
Copy Markdown
Member

I find a mention of typescript but not babel “with prejudice”; why was that change made?

Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
jchip and others added 3 commits September 24, 2019 12:14
Co-Authored-By: Vincent Weevers <mail@vincentweevers.nl>
Co-Authored-By: Vincent Weevers <mail@vincentweevers.nl>
Co-Authored-By: Vincent Weevers <mail@vincentweevers.nl>
@jchip

jchip commented Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

I find a mention of typescript but not babel “with prejudice”; why was that change made?

babel itself is not a language but a compiler that transpiles other languages to a target like ES5.

But updated the sentense to:

If a package's original code is written in code that require transpilation to something like ES5, then the original source code probably is not needed but is sometimes still published.

@mhdawson

Copy link
Copy Markdown
Member

@ljharb have your comments been addressed? Once you approve we can make sure others are ok and then move to publishing.

Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved
Comment thread docs/drafts/PUBLISH-BLOG.md Resolved

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jchip and others added 2 commits October 8, 2019 19:29
Co-Authored-By: Michael Dawson <michael_dawson@ca.ibm.com>
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@jchip

jchip commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

@mhdawson ready for merged?

@Eomm
Eomm merged commit 8edc383 into nodejs:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants