This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Repository navigation
feat: expose isDirect boolean for direct dependencies on the Vuln type - #323
Merged
Merged
Conversation
This was referenced Sep 20, 2021
Contributor
|
Adjusted the code a bit so that workspace dependencies are also considered "direct", and replaced the flatmap with a for loop to exit a bit quicker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in relation to
npm/rfcs#372
I've extracted what can already be merged without much controversy from #301
and provided test coverage.
@isaacs let me know if this is ok now, I'd like to merge this one and use it in npm-audit-resolver
and then go back to working on types - the logic there demands I spend some more time figuring out what I want to achieve in more detail than I initially anticipated.