Repository navigation
validRange doesn't format x-ranges correctly #183
Description
Currently semver.validRange doesn't correctly format unions containing full x-ranges.
validRange('*') // good: '*'
validRange('* || 1.0.0') // bad: '||1.0.0'
validRange('* || *') // bad: '||'I would recommend simply returning '*' if any of the components are '*', like such:
validRange('*') // '*'
validRange('* || 1.0.0') // '*'
validRange('* || *') // '*'relevant code:
semver.js#L709
semver.js#L1107
Activity
[-]validRange doesn't format asterisks correctly[/-][+]validRange doesn't format x-ranges correctly[/+]isaacs commentedon Jan 30, 2017
But those aren't actually identical.
Consider that
*doesn't match (by design)1.0.0-prerelease. So,* || 1.0.0-prereleaseis different than*.Since a blank range is equivalent to
*,||1.0.0-prereleaseactually is identical to* || 1.0.0-prerelease.I agree that it would be nice to omit identical ranges that exist between
||characters. Thus*||*would reduce to||and then merely a blank line, which would be replaced by*(which is there to support checks that doif(validRange(...))and expectnullto be the only non-truthy return value). We could also remove ranges in the set that don't have any prerelease parts if there's a*. Patches welcome for those enhancements.But what's there now is not semantically incorrect, and is working as intended.