Repository navigation
Allow script-shell config in package.json - #36
danielbayley wants to merge 1 commit into
Conversation
|
Which would take precedence if both files are defined? Wouldn’t this make |
|
My main objection to this is that it seems weird to pick out this config value as the only one to set as a project-level config in package.json. It seems easy enough to just add a blessed package.json object that would do project-level configs. The pattern in other node tools (babel, typescript, jest, tap, and nyc, that I'm aware of) is to use the name of the tool as the field name. So it'd look something like this: {
"name": "my-project",
"version": "1.2.3",
"npm": {
"script-shell": "/bin/bash",
"other-thing": "blarg"
}
}I don't think that'd be too terrible performance-wise, but it would mean that we have to update the config handling logic to treat both |
Bot-generated transition of RFC **#36** to status `implemented`. Moved to `implemented/0036-overrides.md`. Front-matter `status` and the relevant date field were updated. `INDEX.md` was regenerated. Implementation: npm/arborist#354 Co-authored-by: npm CLI robot <npm-cli+bot@github.com>
RFC proposing that
script-shellbe directly configurable frompackage.json.Rendered