feat: sponsors improvements - #2966
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughSponsor data is split into gold and silver tiers, and the About page, footer, and README now render or link to those sponsors with updated locale and schema strings. ChangesSponsor tiers across site
Sequence Diagram(s)sequenceDiagram
participant AppFooter as AppFooter.vue
participant SponsorData as SPONSORS.gold/silver
participant ListFormat as Intl.ListFormat
participant Locale as locale
participant FooterLabel as footer.sponsored_by
AppFooter->>SponsorData: read sponsor names
AppFooter->>Locale: read current locale
AppFooter->>ListFormat: format sponsor names
AppFooter->>FooterLabel: translate "Sponsored by {list}"
FooterLabel-->>AppFooter: render sponsor line
Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/components/AppFooter.vue`:
- Around line 172-177: The sponsors link in AppFooter.vue is using a raw anchor
for an internal route, which causes a full page reload. Replace the `<a>` in the
footer sponsor section with `LinkBase` so navigation stays consistent with the
rest of the footer while preserving the existing `/about#sponsors` destination
and translated label.
In `@README.md`:
- Around line 209-213: The README sponsors section uses a static sponsors.png
image, so update the sponsors embed to be theme-aware. Replace the current image
in the Sponsors block with a <picture> or equivalent prefers-color-scheme setup
that references the existing light/dark sponsor assets under
app/assets/logos/sponsors, so the displayed image matches the user’s theme.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ee8259e6-6d71-4b96-b8f7-84a2e56d09b6
⛔ Files ignored due to path filters (3)
app/assets/logos/sponsors/coderabbit-light.svgis excluded by!**/*.svgapp/assets/logos/sponsors/coderabbit.svgis excluded by!**/*.svgassets/media/sponsors.pngis excluded by!**/*.png
📒 Files selected for processing (6)
README.mdapp/assets/logos/sponsors/index.tsapp/components/AppFooter.vueapp/pages/about.vuei18n/locales/en.jsoni18n/schema.json
|
Thanks a ton for taking care of this one Alex 🙏 |
|
@alexdln i might be mistaken, but i couldn't find the previous sponsor organizations in the preview. Was that intentional? |
|
@BittuBarnwal7479 We don't have any of those :) |
Ah, got it! Thanks for the clarification. I assumed there were additional previous sponsors. 😄 |

🔗 Linked issue
Resolves #2962
🧭 Context
Screenshors
Readme - https://github.com/alexdln/npmx.dev/tree/feat/sposors-improvements

Footer - https://npmxdev-git-fork-alexdln-feat-sposors-improvements-npmx.vercel.app/

About page - https://npmxdev-git-fork-alexdln-feat-sposors-improvements-npmx.vercel.app/about
