Skip to content

fix(i18n): added missing RU translations - #3083

Merged
gameroman merged 2 commits into
npmx-dev:mainfrom
nikelborm:ru-i18n-missing
Jul 25, 2026
Merged

fix(i18n): added missing RU translations#3083
gameroman merged 2 commits into
npmx-dev:mainfrom
nikelborm:ru-i18n-missing

Conversation

@nikelborm

@nikelborm nikelborm commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Please ensure there is an open issue and mention its number. For example, "resolves #123"

Does it have to be done even for such small changes?

🧭 Context

Some RU translations were missing

📚 Description

PR adds missing RU translations.

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 25, 2026 11:37pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 25, 2026 11:37pm
npmx-lunaria Ignored Ignored Jul 25, 2026 11:37pm

Request Review

@github-actions

github-actions Bot commented Jul 25, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ru-RU.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a70aed0e-1856-465e-8539-e6d655b88c2c

📥 Commits

Reviewing files that changed from the base of the PR and between 24534e6 and c8e1f0e.

📒 Files selected for processing (1)
  • i18n/locales/ru-RU.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • i18n/locales/ru-RU.json

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added Russian translations for foreground theme options, including contrast, standard, and muted variants.
    • Added translated messages for copying package versions and announcing foreground theme changes.
    • Added Russian text for empty noodle bowls and potentially unnecessary code warnings.

Walkthrough

The Russian locale adds translations for foreground theme selection, command-palette announcements, missing-content states, package version copying, and code viewer messaging.

Changes

Russian locale updates

Layer / File(s) Summary
Foreground theme translations
i18n/locales/ru-RU.json
Adds foreground theme labels and variants, plus the command-palette announcement for foreground theme changes.
Interface message translations
i18n/locales/ru-RU.json
Adds messages for empty missing content, copying package versions, and potentially unnecessary code.

Possibly related PRs

  • npmx-dev/npmx.dev#2621: Adds related Russian translations for foreground theme selection and command-palette support.

Suggested reviewers: ghostdevv

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR changes RU translation strings, not the README markdown extension support requested by issue #123. Update the code to implement .markdown README support, or retarget the linked issue if this PR is only for translations.
Out of Scope Changes check ⚠️ Warning The translation-only edits are unrelated to issue #123's README extension work. Remove the translation-only edits from this PR or split them into a separate i18n PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the PR's main change: adding missing Russian translations.
Description check ✅ Passed The description matches the translation-focused changes and is not off-topic.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nikelborm nikelborm changed the title fix(i18n): Added missing RU translations fix(i18n): added missing RU translations Jul 25, 2026
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@i18n/locales/ru-RU.json`:
- Line 194: Update the Russian translations for foreground_themes.label and
foreground_theme_changed to consistently use “Цвет текста” terminology instead
of “Основной цвет,” while preserving the existing placeholders and message
structure.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 351458f6-49b8-40d9-938b-691ed7b7c63c

📥 Commits

Reviewing files that changed from the base of the PR and between 0690eef and 24534e6.

📒 Files selected for processing (1)
  • i18n/locales/ru-RU.json

Comment thread i18n/locales/ru-RU.json
Comment thread i18n/locales/ru-RU.json Outdated
Co-authored-by: Roman <dev@rman.dev>

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think

@gameroman
gameroman added this pull request to the merge queue Jul 25, 2026
Merged via the queue into npmx-dev:main with commit 2c78c40 Jul 25, 2026
24 checks passed
@github-actions

Copy link
Copy Markdown

Thanks for your first contribution, @nikelborm! 🎉

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants