Repository navigation
fix(dotnet): stop inferring publish and run on test projects - #37511
Draft
AgentEnder wants to merge 1 commit into
Draft
AgentEnder wants to merge 1 commit into
AgentEnder wants to merge 1 commit into
Conversation
Test projects evaluate to OutputType=Exe because Microsoft.NET.Test.Sdk sets it on .NET Core and MTP runners set it themselves, so every test project got publish and run targets. Gate both on the project not being a test project, and drop the unused isTest parameter from AddPublishTarget. Part of NXC-5119
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 33916a7
☁️ Nx Cloud last updated this comment at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
We infer
publishandrunfor any project withOutputType=Exe. Test projects evaluate toExe(Microsoft.NET.Test.Sdk sets it on .NET Core, and MTP runners set it themselves), so every test project getspublishandruntargets.Expected Behavior
Test projects don't get
publishorrun.Related Issue(s)
Part of NXC-5119