Repository navigation
fix(release): push release commit and tags after they are created - #37568
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
With
release.git.push: trueand nocreateRelease,nx releasepushes right after versioning while the changes are only staged (the version step falls back togit.push), and then never pushes again after committing and tagging. So the release commit and tags never reach the remote.Expected Behavior
releaseVersionis called withgitPush: false, andnx releasepushes once after commit and tag whengit.pushis enabled (or--git-pushis passed), or when a remote release is configured like before.--no-git-pushand dry run still work. Addedrelease.spec.tscovering the push order and the push disabled case.Related Issue(s)
Fixes #37427