Skip to content

fix(core): bump undici to ^7.29.1 to resolve security advisories - #37569

Open
AgentEnder wants to merge 1 commit into
masterfrom
fix/core-undici-advisories
Open

AgentEnder wants to merge 1 commit into
masterfrom
fix/core-undici-advisories

Conversation

@AgentEnder

Copy link
Copy Markdown
Member

Current Behavior

nx depends on undici@^7.29.0. Lockfiles that resolved 7.29.0 make npm audit report ten advisories (one high), including GHSA-3wwx-pv8p-q78v and GHSA-w293-vg96-wgc3.

Expected Behavior

The range is now ^7.29.1, which is the first 7.x release that patches all ten. Because 7.29.0 no longer satisfies the range, a lockfile that still holds it gets refreshed. The repo lockfile resolves 7.30.1.

This PR keeps Nx on undici 7. undici 8 requires Node >=22.19.0, so moving to it would change the supported Node floor and should go in a separate PR.

Related Issue(s)

Fixes #37331


View Polygraph session ↗

undici 7.29.0 is affected by ten advisories, all patched in 7.29.1.
Raising the floor keeps lockfiles that already hold 7.29.0 from
satisfying the range.

Fixes #37331
@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 9b97972
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/6ada2fb4eeb39307a5cc966d
😎 Deploy Preview https://deploy-preview-37569--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 9b97972
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/6ada2fb4aa091a18e6d022d2
😎 Deploy Preview https://deploy-preview-37569--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud

nx-cloud Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 9b97972

Command Status Duration Result
nx affected --targets=lint,oxlint,test,build,e2... ❌ Failed 33m 27s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 48s View ↗
nx build workspace-plugin ✅ Succeeded 1m 58s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 32s View ↗
nx-cloud record -- nx format:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-22 16:25:51 UTC

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​undici@​7.30.19310010098100

View full report

@AgentEnder
AgentEnder marked this pull request as ready for review October 22, 2026 15:56
@AgentEnder
AgentEnder requested a review from a team as a code owner October 22, 2026 15:56
@AgentEnder
AgentEnder enabled auto-merge (squash) October 22, 2026 15:56

@nx-cloud nx-cloud Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a possible root cause for your failed CI:

We looked into the failed populate-e2e-base-workspace task. Our yarn base workspaces failed with "Release not found: 1.22.22" during yarn set version 1.22.22, which is an external release lookup problem and not related to the undici bump in this PR. We aren't suggesting any code changes.

No code changes were suggested for this issue.

Trigger a rerun:

Rerun CI

Nx Cloud View detailed reasoning on Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nx 23.3.0 depends on vulnerable Undici versions

2 participants