Repository navigation
fix(core): keep Node's conditions container type in the resolve hook - #37576
Open
sarankumar1325 wants to merge 1 commit into
Open
sarankumar1325 wants to merge 1 commit into
sarankumar1325 wants to merge 1 commit into
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
On Node 22.18, any
nxcommand in a workspace that loads a local TypeScript plugin from source fails withconditions.has is not a function. Insidenx runit shows up as the misleadingCould not find runner configuration for default.ensureResolveConditionsInjectedregisters amodule.registerHooks()resolve hook that appends the tsconfig conditions (e.g.development) and always passes an array tonextResolve. Node 22.18's CJS resolver hands the hook aSet(SafeSet) and calls.has()on what it gets back. Newer Node (22.21, 26) passes an array and rejects aSet, which is why it only breaks on some 22.x versions.Expected Behavior
The hook keeps whatever container Node passed in: an array stays an array, and a Set-like value gets a
Setback. The merge is in a small exportedmergeResolveConditionshelper with unit tests inregister.spec.ts. Node'sSafeSetis notinstanceof Set, so the check isArray.isArray.I checked the hook with a package that has a
developmentexport condition:require()resolves to the development entry on Node 22.18.0, 22.21.0 and 26.12.1. Before the change, 22.18.0 throwsconditions.has is not a function.This PR doesn't change
getRunnerswallowing the original error (the second point in the issue).I used an AI assistant while working on this and reviewed the change myself.
Related Issue(s)
Fixes #37502