Repository navigation
Conversation
Configs extended by a project's internal project references (e.g. a shared root tsconfig.lib.base.json) are now typecheck and build inputs and part of the createNodes cache key. Previously editing them affected no projects and left inferred targets stale.
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for nx-dev pending review.Visit the deploys page to approve it
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/js/typescriptfollowsextendsonly for the tsconfig a target is inferred from, not for that tsconfig's internal project references. In this common layout:tsconfig.lib.base.jsonis not atypecheckinput, so editing it affects no projects and keeps stale cache hits. It is also missing from the createNodes cache key, so inferred targets don't update when it changes (e.g. its${configDir}include).Expected Behavior
Configs extended by internal project references, recursively, are
typecheckandbuildinputs and part of the createNodes cache key. Duplicate config inputs are dropped, since references usually extend./tsconfig.json.Related Issue(s)
None filed. #35457 fixed this for external references only. It skips workspace-root files, assuming the project's own
extendswalk covers them, which isn't true for internal references.