Repository navigation
ci: add format check and pr autofix - #368
Conversation
mise run lint now runs prettier --check (lint:format), and format.yml runs mise run format on same-repo PRs with the automation App token and pushes the fixes as a new commit, so CI re-runs on it. Fork PRs get a warning. REQ-ENG-006 moves to partial (eslint --fix still missing); the docs no longer claim bun run lint runs Prettier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GA968hkqa7CsMeYAhzV4Dz
Prettier should fail lint on this commit, and format.yml should push a fix that restores the original line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GA968hkqa7CsMeYAhzV4Dz
Release Version Check
This version will be released automatically when this PR is merged to |
Preview DeploymentThe web app for this PR has been deployed: Use this to verify the app works correctly, especially for dependency updates. |
|
Autofix acceptance check: passed.
Generated by Claude Code |
Addresses review: the autofix guard now also checks untracked files and stages everything before committing, and the CONTRIBUTING.md formatting bullet is split into sentences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GA968hkqa7CsMeYAhzV4Dz
There was a problem hiding this comment.
### ✅ Post-merge re-review — no new content since prior APPROVE
- ✅ PR is already merged (merge commit
11dc06b) at head SHA c68427a.
- ✅ My prior APPROVED review (PRR_kwDORdvHSc8AAAABRP8tnQ) was against this exact SHA; the diff hasn't changed since.
- ✅ All four previous inline threads are resolved (3× P2 addressed by author, 1 info note confirmed).
- ✅ No new findings in a fresh pass over
format.yml, commit-format-fixes.sh, .mise.toml, and the REQ-ENG-006 doc edits.
Click to expand for full details
11dc06b) at head SHA c68427a.format.yml, commit-format-fixes.sh, .mise.toml, and the REQ-ENG-006 doc edits.Why this is a comment, not an approve
A fresh APPROVE on a merged PR adds noise; my previous APPROVE already stands against the merged SHA. Posting as COMMENT here just records that this re-review run found nothing new.
How I re-checked
gh pr view 368confirmedstate: MERGED,headRefOid: c68427a…,mergeCommit.oid: 11dc06b….gh pr diff 368matched the diff I reviewed previously — zero new commits sincec68427a1.- Verified all four review threads (
PRRT_kwDORdvHSc6qOsmn,…sw6,…s8H,…tK8) are alreadyisResolved: true. - Minimized my two prior review bodies as
OUTDATEDso the thread view stays clean. The APPROVE verdict forc68427aremains in the review history.
Nothing re-opened
.github/workflows/format.yml: stillpull_request(not_target), App token gated byhead.repo.full_name == github.repository, SHA-pinnedcheckout-as-app.scripts/ci/commit-format-fixes.sh: untracked-files guard +git add --allfromc68427apresent.- Docs: REQ-ENG-006 is
partial / documented / currentwitheslint --fixcalled out as the remaining gap; CLAUDE.md and CONTRIBUTING.md no longer claimbun run lintruns Prettier; Open Question 2 is marked decided.
Follow-ups: none for this PR.
- (Tracked separately, not for this PR.)
eslint --fixwiring once REQ-ENG-007 extends ESLint coverage — already captured in REQ-ENG-006 "Gap".
References
- Workflow run: https://github.com/nsheaps/.ai-agent-henry/actions/runs/37738578193
- Prior APPROVE:
PRR_kwDORdvHSc8AAAABRP8tnQ(now minimized as OUTDATED — verdict still applies to the merged SHA) - GitHub docs — Minimizing conversations
Phase 1 plan, M0 PR 6 (REQ-ENG-006). Builds on #367, which formatted the repo and added
.prettierignore.Changes
mise run lintchecks formatting. A newlint:formattask runsprettier --check ., andlintdepends on it, so the lint job fails on unformatted files..github/workflows/format.ymlautofixes PRs from this repo.checkout-as-app, SHA-pinned), runsmise run format, and pushes any changes asstyle: apply prettier formattingviascripts/ci/commit-format-fixes.sh.GITHUB_TOKEN, so CI re-runs on the autofix commit. It never adds[skip ci].mise run format, and their lint job still fails.eslint --fixis still missing.bun run lintruns Prettier, and they listmise run lint:formatandmise run format.Test plan
mise run lint:formatfail, and it passed once the file was removed.mise run lint:workflowspasses (actionlint, shellcheck, single-commandrun:steps).mise run checkpasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01GA968hkqa7CsMeYAhzV4Dz
Generated by Claude Code