Say which view the dashboard is on, reach the machine's settings, and stop pushing views down - #99
Merged
Merged
Conversation
added 3 commits
September 23, 2026 03:01
… stop pushing views down Four faults found by walking every view in a browser against a sandboxed dashboard, measuring rather than looking. Where notices go, the trigger token, the listen address and the office art could not be changed from the dashboard at all. The fold holding them and the Settings page were both id="settings"; getElementById returns the first, so fillSettings unhid the page instead of the fold, and the fold stayed hidden under the runs list from the day the Settings page arrived (0324df9, 20 Sep). It is id="machine" now and moves onto the Settings page, as "What this machine is set to", when that page is first drawn; until then a rule keeps it out of sight in the runs pane. Switching view changed nothing a screen reader would say. Focus stayed on the button, the heading read "Runs on this machine" over the office, the graph and the timeline, and the address never changed, so Back and a bookmark could not reach a view. Each view now has its own heading; a view somebody chose takes the focus at that heading (not one the page opens on, nor one Back returns to); the address carries #office, #graph and so on, the page opens on the view it names, and Back and Forward move between them. The token stays in the query. Starting a team, making one, scheduling one, clearing runs out and how the roles have done sat above every view, so the office, the graph and the timeline began 280 pixels down. They show on the list only. A short view pushed the whole page down. The page is a grid at least a window tall, and with nothing saying which row takes the spare height the header row grew to 192 pixels over 69 of header on Waiting and Settings. The content row takes it now. Checked in Chrome at 1280 by 800: every view's heading, focus and address; the ledger at 109 px on every view, Waiting included (224 before); the start form on the list alone; opening on #waiting; Back from the graph to the list; the notice and listen controls visible on Settings and absent from the list before and after visiting it.
So a reader knows they can bookmark #office and that Back returns to the screen they were on, and that choosing a screen moves the focus to its heading, which is what a screen reader reads out.
# Conflicts: # tests/Loadout.Tests/Integration/DashboardServerTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes four dashboard faults, found by walking every view in Chrome against a sandboxed dashboard and measuring rather than eyeballing.
id="settings".getElementByIdreturns the first, sofillSettingsunhid the page instead of the fold, and the fold stayed hidden under the runs list. That's been true since the Settings page arrived (0324df9, 20 Sep): where notices go, the trigger token, the listen address and the office art couldn't be changed from the dashboard. The fold is nowid="machine"and moves onto the Settings page when that page is first drawn. Until then, a rule keeps it hidden in the runs pane.#office,#graphand so on, the page opens on the view it names, and Back and Forward move between views. The token stays in the query string.grid-template-rows: auto minmax(0, 1fr), andauto auto minmax(0, 1fr)on narrow windows).The dashboard guide gains a short paragraph on the address and focus.
Evidence
DashboardServerTests, each failing before the change:Every_id_on_the_page_is_used_once: before, it found{"settings"}.A_view_says_what_it_is_and_takes_the_focus.A_short_view_does_not_push_the_page_down.The_page_offers_a_way_to_start_onematched the exact tag<details class="start">. The fold now has an id, so the string was updated; the test's point is unchanged.#waitinglands on Waiting without taking focus, and Back goes from Graph to List.node --check.Not verified
document.activeElement, not by listening.