Various bug fixes and improvements - #124
Merged
Merged
Conversation
Still need some more comprehensive regression tests
When the window list service goes down, always clear out all the window content workers. Always wait a second before refreshing the windows to give the others a chance to catch up.
Owner
Author
There was a problem hiding this comment.
This stuff should be factored into the state machine. It's conditional on the state machine's state, and is intended to modify a state machine action (displaying the interface).
Owner
Author
There was a problem hiding this comment.
In an ideal world, this will break when #122 gets fixed, as activeApplication should become an immutable data property.
Unfortunately, refreshWindowList won't dispatch a notification if there is only a change in active application, so that'll have to happen later. Sorry, future me.
numist
added a commit
that referenced
this pull request
May 13, 2015
Various bug fixes and improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch got away from me a little bit.