Repository navigation
Support variadic Lua arguments with ReadOnlySpan/ReadOnlyMemory - #255
Merged
Merged
Conversation
akeit0
marked this pull request as draft
May 1, 2026 05:53
akeit0
marked this pull request as ready for review
October 10, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated LuaObject bindings can now pass the remaining Lua arguments to a final ReadOnlySpan or ReadOnlyMemory parameter, optionally followed by an injected CancellationToken. For example, an instance method Sum(double first, ReadOnlySpan rest) called as obj:Sum(1, 2, 3) receives first = 1 and rest = [2, 3]. This removes the need for a handwritten LuaFunction wrapper for variadic C# methods.
The view excludes the instance receiver and consumed fixed arguments. Out parameters consume no Lua arguments, zero remaining arguments produces an empty view, and nil values remain present. Missing optional fixed arguments, ref/out return values, inherited methods and index/newindex/call metamethods are covered. Parameter classification is guarded for token-only methods, uses the existing ArgumentsMemory API, and keeps unsupported signatures as located diagnostics.
ReadOnlyMemory supports reading the arguments after await while the host call is active. Both types borrow the Lua stack; copy with ToArray() to retain values after returning. Only by-value views with LuaValue elements in the final non-token position are supported. Mutable views and C# params LuaValue[] remain unsupported. The README documents usage and lifetime constraints. No runtime/VM/API changes are required.
Validation:
Related: #150 and #254.