Repository navigation
Fix method receiver preservation during __index lookup - #347
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling obj:method(...) through a Lua __index function could pass a stale stack value as self, including a Vector3 left by a previous property setter. SELF saved the receiver only on the synchronous return path; Lua metamethod execution could reuse its slot first. The async/hook completion path also reread register B, which lookup itself can change.
Save and protect the original receiver before method lookup, matching Lua 5.2's SELF ordering. Completion writes only the method result. Reacquire the destination from the current stack buffer after synchronous C# lookup, since that callback can resize the buffer.
Fixes #344.
Validation:
The Lua __index timing harness deliberately ignores self so both versions complete; main is semantically incorrect on that path, and the regression tests separately assert receiver identity. This is a correctness fix with a measured cost on Lua function lookup, rather than a claim of universal performance improvement.