Repository navigation
Suppress documentation and obsolete warnings in generated wrappers - #349
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating a public
[LuaObject]with XML documentation enabled currently produces CS1591 for its generated implicit conversion. Exposing obsolete members also produces CS0612/CS0618 at the generated wrapper's call sites. These generated warnings can break builds that treat warnings as errors.Suppress CS1591, CS0612 and CS0618 inside generated files, with matching restore directives and comments explaining the scope. This follows the existing generator warning policy and the precedent in .NET's COM generator and JSON generator. Handwritten code retains its documentation and obsolete-use diagnostics;
Obsolete(..., true)errors remain errors. Generated runtime code and public API signatures are unchanged.Fixes #311.
Validation:
ExpectedFailure: 322 passed.fb33179.This PR remains unmerged for review.