Repository navigation
Restore count hooks after aborted callbacks - #353
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a count hook threw, was cancelled, or could not allocate its call frame at the depth limit,
IsInHookremained set after the host caught the error. Later executions on the same LuaState silently suppressed hooks, even after reinstalling them. Restore the flag in afinallycovering frame setup and callback execution so hooks work when the state is reused.Add regression coverage for synchronous/asynchronous runtime and host exceptions, cancellation, and frame-depth failure followed by reuse. Also cover callback rearming/replacement/removal, recursive hook suppression, and synchronous/asynchronous host boundaries. Document these behaviors and timeout/memory/error limitations in SetHook API comments and both READMEs.
Refs #338. This PR addresses correctness and documents the observations. The lightweight delegate and first-class budget proposals are deferred; #338 should remain open.
Validation:
Temporary probes, experimental APIs and reports are outside Git and are not included in this PR.