Repository navigation
Restore hooks after frame setup failures - #354
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line, call, return, and the immediate
debug.sethookreturn callback left hooks suppressed when their frame setup exceededMaxCallDepth. Protect frame setup with the same cleanup as callback invocation, and pop a hook frame only after a successful push so setup errors preserve the caller and original exception.Also suppress immediate return-hook dispatch when
debug.sethookis called inside a hook. This preserves the documented nonrecursive callback behavior, consistent with Lua 5.2'sluaD_hook.Validation:
Refs #338. Lightweight delegate/budget API proposals remain deferred; this PR covers hook correctness only.