Repository navigation
Preserve enum values with colliding Go names - #2678
Merged
mromaszewicz merged 2 commits intoNov 21, 2026
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe PR preserves enum values when different names become the same Go name.
Reviews (2) · Last reviewed commit: "test: cover old-enum-conflicts enum name..." · Reviewed by Greptile |
Exercise the `compatibility.old-enum-conflicts` branch of the enum naming fix: names that collide after the path-prefixed conversion each keep a constant, and a numeric suffix skips a name owned by a later value. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
mromaszewicz
approved these changes
Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2674.
Allocate unique names after the final schema-name conversion, and reserve existing suffixes when naming server URL variables. This preserves the declared enum values and keeps the default tied to the correct value.
Verified both paths with the generated Go.
make tidy,make test,make generate, andmake lintpassed.