Skip to content

fix: add reentrancy protection tests and attacker contract for Issue #2 - #6

Open
ansdaood wants to merge 1 commit into
odiseo159-beep:mainfrom
ansdaood:main
Open

ansdaood wants to merge 1 commit into
odiseo159-beep:mainfrom
ansdaood:main

Conversation

@ansdaood

Copy link
Copy Markdown

Añade el contrato atacante y las pruebas de reentrancy para resolver el Issue #2.

@odiseo159-beep

Copy link
Copy Markdown
Owner

Thanks for this. Two things stand between it and a payment.

1. The description has no bounty line. The agent reads that line to know what to settle, so without it a merge pays nobody. Please edit the description to include:

Bounty: #10

That is the bounty on chain for this issue: 0.0005 ETH locked on GIWA Sepolia until 25 October.

2. The agent cannot find your wallet yet. ansdaood is not registered on chain and your profile README has no Mergit line. Pick either:

  • Add one line to the README of ansdaood/ansdaood, naming Mergit and your address. Free, nothing to connect, nothing to sign. Example: Mergit: my wallet is 0xYourAddress
  • Or register the login on chain at https://www.mergit.xyz/register

One more thing: this branch also changes contracts/package-lock.json. If that was not intentional, please drop it, so the diff stays to the tests and the helper contract.

CI has not run yet because this is your first contribution here; I will approve it. Once it is green and the points above are done, merging pays you by itself.

Heads up that #3 is also open against this same bounty. One bounty, one payment: the first pull request merged takes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants