Skip to content

fix: tolerate npm metadata propagation delay - #13

Merged
oll4com merged 1 commit into
mainfrom
fix/npm-metadata-propagation-20260724
Jul 24, 2026
Merged

oll4com merged 1 commit into
mainfrom
fix/npm-metadata-propagation-20260724

Conversation

@oll4com

@oll4com oll4com commented Jul 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • retry staged npm metadata checks while the registry propagates a successful OIDC publish
  • keep the verification bounded and fail closed after 12 attempts
  • pass release identity through quoted environment variables
  • add regression assertions for the retry contract

Root cause

Release 0.1.5 published successfully with provenance, but the immediate npm view ran about 30 ms later and briefly returned E404 before registry propagation completed.

Verification

  • RED: focused public workflow test failed before the workflow change
  • GREEN: focused workflow suite 6/6
  • public policy suite 57/57
  • launcher suite 43/43
  • runtime/API/Web suites passed
  • npm run check
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes

    • Improved release verification to handle delays in package metadata updates.
    • Releases now retry validation for up to 12 attempts before failing with a clear error message.
    • Verification confirms the published version, release tag, and commit information are consistent before completion.
  • Tests

    • Added coverage for retry behavior, timing, release metadata, and failure handling.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 23067185-f732-4571-8298-2f6f47a65f64

📥 Commits

Reviewing files that changed from the base of the PR and between e5e8bcd and 13401f9.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • scripts/tests/public-workflows.test.mjs

📝 Walkthrough

Walkthrough

The release workflow replaces single-shot npm metadata assertions with a 12-attempt retry loop using release version and commit environment variables. Workflow tests now verify the retry count, five-second delay, environment variables, and final failure message.

Changes

Release metadata consistency

Layer / File(s) Summary
Retry-based release validation
.github/workflows/release.yml, scripts/tests/public-workflows.test.mjs
The workflow retries published version, next dist-tag, and gitHead checks up to 12 times, while tests verify the environment variables, delay, retry count, and failure message.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main change: retrying npm metadata checks to tolerate registry propagation delay.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oll4com
oll4com merged commit 3f88521 into main Jul 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant