Repository navigation
fix(installer): remove browser when switching to light - #23
Conversation
Compose does not classify a service disabled by profiles as an orphan. Stop and remove the managed browser container explicitly during successful light installs while preserving its storage and all other volumes.
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis release updates run-spaceapp to 0.1.14 and adds light-profile cleanup for managed browser containers. Installation and refresh invoke a standard-profile forced removal without deleting volumes, with tests covering command construction, idempotency, version state, and cleanup failures. ChangesRelease metadata and version assertions
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/run-spaceapp/src/cli.mjs`:
- Around line 425-441: Update the installation flow around persistSetupToken and
the light-profile removeBrowser cleanup so setup-token persistence remains
atomic with commitInstallation. Defer persisting the new token until cleanup
succeeds, or restore the previous token before returning when removeBrowserCode
is nonzero, ensuring failed installations cannot leave a token without the
corresponding committed config.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 47731fc3-d224-401c-bc06-3e43c4f31743
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (9)
CHANGELOG.mddocs/public-release.mdpackages/run-spaceapp/package.jsonpackages/run-spaceapp/src/cli.mjspackages/run-spaceapp/src/index.mjspackages/run-spaceapp/tests/cli.test.mjspackages/run-spaceapp/tests/command-contracts.test.mjspackages/run-spaceapp/tests/runtime.test.mjsscripts/tests/public-package-metadata.test.mjs
Delay setup-token persistence until browser cleanup succeeds so failed light installs leave all committed host state unchanged.
Summary
lightinstallstandard -> lightupgrades and state left by the unpromoted0.1.13candidate0.1.14Root cause
Docker Compose does not classify a service disabled by profiles as an orphan. As a result,
up -d --remove-orphansretained an already-runningspaceapp-browsercontainer when an existingstandardinstallation moved tolight.Verification
npm run test:publicpassednpm run checkpassednpm run buildpassednpm audit --audit-level=high: 0 vulnerabilitiesnpm pack --dry-run:run-spaceapp@0.1.14, 11 filesSafety
The cleanup uses fixed Compose argv with
--profile standard rm --stop --force spaceapp-browser. It does not run Composedownor pass--volumes. Failed cleanup returns before committing new installer configuration/runtime files.Summary by CodeRabbit
New Features
Release
0.1.14with updated installation, upgrade, refresh, and rollback guidance.