Repository navigation
fix(release): publish Linux x64 host-root candidate #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Route
inputs.version/inputs.browser_source_versionthroughenv:instead of interpolating them directly intorun:scripts. All four new amd64-core-cli steps expand workflow_dispatch inputs directly via${{ }}inside shell command text; zizmor flags this as template injection at each site. The existingrelease-policystep in the same file already demonstrates the safe pattern (passing inputs viaenv:and referencing$VAR)..github/workflows/release.yml#L364-L369: addenv: BROWSER_SOURCE_VERSION: ${{ inputs.browser_source_version }}and reference"$BROWSER_SOURCE_VERSION"in the--versionargument..github/workflows/release.yml#L507-L511: addenv: RELEASE_VERSION: ${{ inputs.version }}and reference"$RELEASE_VERSION"in the tar archive filename..github/workflows/release.yml#L553-L557: addenv:entries for bothRELEASE_VERSIONandBROWSER_SOURCE_VERSIONand reference$RELEASE_VERSION/$BROWSER_SOURCE_VERSIONin thedocker buildx imagetools createtags..github/workflows/release.yml#L612-L617: addenv: RELEASE_VERSION: ${{ inputs.version }}and reference"$RELEASE_VERSION"in the--versionargument.🧰 Tools
🪛 zizmor (1.26.1)
[error] 367-367: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
📍 Affects 1 file
.github/workflows/release.yml#L364-L369(this comment).github/workflows/release.yml#L507-L511.github/workflows/release.yml#L553-L557.github/workflows/release.yml#L612-L617🤖 Prompt for AI Agents
Source: Linters/SAST tools