Repository navigation
feat(observability): trace Temporal workflows and activity attempts over OTLP #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
pythonyx135793
wants to merge
9
commits into
oll4com:main
from
pythonyx135793:codex/worker-otlp-tracing
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5f55d3c
feat(observability): export connected Temporal workflow and activity …
pythonyx135793 77d9b73
test(observability): include shared exporter in public build order
pythonyx135793 ce277e8
ci: run worker tracing checks on pull requests and main
pythonyx135793 3df9796
Merge current main and preserve shared worker OTLP tracing
pythonyx135793 070ca37
fix(web): dispose clipboard copy feedback with its dock
pythonyx135793 0bb0443
docs(observability): explain trace propagation and exporter contracts
pythonyx135793 cf3e2bc
fix(tracing): parent queued turns to their originating request
pythonyx135793 bb36d9c
Merge current main while preserving worker tracing and reload cleanup
pythonyx135793 a862434
fix(worker): close tracing when main worker startup fails
pythonyx135793 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| name: Worker OTLP validation | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, codex/worker-otlp-tracing] | ||
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: worker-otlp-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| ELECTRON_SKIP_BINARY_DOWNLOAD: "1" | ||
|
|
||
| jobs: | ||
| tracing: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| - run: npm ci --no-audit --no-fund | ||
| - run: npm run check | ||
| - run: npm test -w @space/observability | ||
| - run: npm test -w @space/worker | ||
| - run: npm test -w @space/api -- otlp trace-correlation dot-goals memory-consolidation-coordinator memory-mutation-coordinator | ||
|
|
||
| repository: | ||
| # The main CI workflow already runs the complete public suite on every PR. | ||
| # Keep this independent full-source check available for manual diagnosis. | ||
| if: github.event_name == 'workflow_dispatch' | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 75 | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| - run: npm ci --no-audit --no-fund | ||
| - name: Install ripgrep for real file-search tests | ||
| run: sudo apt-get update -qq && sudo apt-get install -y -qq ripgrep | ||
| - run: npm run check | ||
| - run: npm test | ||
| - run: npm run build | ||
| if: ${{ !cancelled() }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // Keep the original API import path stable while API and workers share one transport. | ||
| export * from "@space/observability"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.