Repository navigation
drm/asahi: retain state 2 as the T8122 thermal fallback - #135
Open
garymeyerca wants to merge 1 commit into
Open
garymeyerca wants to merge 1 commit into
garymeyerca wants to merge 1 commit into
Conversation
With a T8122 ceiling from one to five, the generic fallback calculation selects that same state as both ceiling and fallback. Increasing the experimental ceiling therefore prevents thermal On/Hold from returning to the default state two. Use the T8122 default ceiling as the fallback while preserving lower requested ceilings and other SoCs. Keep thermal Off behavior unchanged. Cover overheating, failed, missing, stale and stuck readings, and hold mode. Preserve the current M3 Max thermal-zone requirements. The host suite passes 58 tests with compiler warnings denied. Restoring the old fallback calculation fails the four new tests. Full kernel build and higher-clock hardware qualification remain pending. Assisted-by: Codex:GPT-6
garymeyerca
marked this pull request as ready for review
October 16, 2026 22:39
chriskearney
added a commit
to chriskearney/siliconforest-linux
that referenced
this pull request
Oct 18, 2026
…rmal-fallback drm/asahi: m3: keep the T8122 thermal fallback at state 2 (from omacom/linux-aurora#135)
This was referenced Oct 18, 2026
6 tasks
|
A data point for rebasing this: on integration/aurora 4fdd0fc (7.2.11), the commit cherry-picks cleanly. It needs two paths changed, because the M3 modules now live under
With those changes and (Written with TARS, my Claude Code agent.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With thermal control enabled, raising asahi.t8122_pstate_cap from 2 to 3 also raises the current thermal fallback to 3: max.min(ADT_MAX_PSTATE_LIMIT) uses a generic limit of 5. The governor then cannot return to the default state 2 when the sensor fails, becomes stale or stuck, or the temperature rises.
Keep the T8122 thermal On/Hold fallback at the lesser of its selected ceiling and its default state 2. Preserve the existing fallback for other SoCs, lower ceilings and explicit thermal Off. Keep the latest M3 Max thermal-zone requirements intact and update the runtime documentation to describe the T8122 behavior.
Base: integration/aurora ccd21b7.
Validation:
Full integration build and hardware validation (2026-10-16):
7.1.12-2-20261016.135-validate-ARCHfrom combined validation commit 3f707474edf90df80a9fd14c3b47b9459706cc0a, containing this patch and media: apple: isp: restore J613 camera capture on 14.7 firmware #134 on the base above.make ARCH=arm64 LLVM=1 -j4 W=1 allpassed with Clang/LLD 23.1.1, Rust 1.93.1 and bindgen 0.73.2. Build warnings are retained locally; this is not a warning-free build. The release config retains Rust/Asahi and ISP support, uses a unique local version and Zstd-compressed debug sections, and includes the base's J613 display-gate default.asahi.t8122_pstate_cap=3 asahi.m3_boot_pstate=2 asahi.m3_thermal=on asahi.m3_thermal_hot=75, with the existing override exposing 80 candidate Te/Tg/Tp channels throughmacsmc_soc_die.emul_temp, then cleared it; the runtime cap fell from 3 to 2 and subsequently returned to 3 with real readings. A 35-second compute run returned 21,269 correct results; the firmware summary confirmed peak state 3.healthy=1; no new GPU timeout/fault/recovery messages were detected during these checks. Thermal emulation was cleared in the cleanup path.This verifies the bounded cap transition and firmware response on one J613. It does not qualify sensor calibration, complete hotspot coverage, higher states, other boards, long-duration thermal behavior, or a performance improvement. Sensor failure/staleness/hold cases remain host-policy tests; only high-temperature and unchanged-reading behavior were exercised on hardware.
Prepared with Codex assistance.