Repository navigation
Conversation
…S off DPMS off stops the panel's display controller (A472 with the hardware-power selector), and the callbacks of that transition are answered, only on the panel this was measured on, the J514S one (the J516S takes the same path), which the code tells by dcp_v14_board_nits(): an internal panel admitted to the level block of its board record. Only the T6030 record has that block today, but a record that gains it gets the hardware power off with it: the J516C record does with the J516C panel brightness change, sent separately, and the J516C panel would then be stopped as well, where it has not been tried. Give the board record a panel_hw_off flag, set on the T6030 record alone, and send A472 and answer its callbacks only where it is set. Nothing changes on the J514S/J516S, and every other panel is only blanked and leaves those callbacks unhandled, as before. The board test checks the flag on the T6030, J516C, J514C and J613 records. Two lifetime cases use a record with levels but without the flag: DPMS off and on only blank its panel and find no controller to restart, and the five callbacks stay unhandled there while the T6030 record answers them. Generated-by: LLM Signed-off-by: Samuel Carreño <soyminero11yt@gmail.com>
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. #283 tells the J514S/J516S panel by its level block (
dcp_v14_board_nits()), both for the A472 power off on DPMS off and for the five callbacks of that transition, which the #274 review asked to keep to those panels. #259 gives the J516C record that block for its brightness, so with both merged, DPMS off would also stop the J516C panel's display controller, which hasn't been tried on it, and the J516C session would answer those callbacks.Change. One commit on top of
feat/m3-pro-panel-dark-sleep(71019b83a624), for you to take or leave:drm/apple: v14.7: Stop only the J514S/J516S panel's controller on DPMS off. It adds apanel_hw_offflag to the board record, set on the T6030 record only, so panel levels and the A472 path are admitted separately. Nothing changes on J514S/J516S,appledrm.panel_hw_off=0included; every other panel is only blanked and leaves those callbacks unhandled, with or without levels.Checked on this branch (arm64, clang 21):
W=1and no warnings.dcp_v14_board_nits()alone does.check-commits.pyis clean.Not checked.
🤖 Generated with Claude Code