You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(overlay): Windows cadence bench Start-LineReader must not AddArgument($null) #1269
Windows PowerShell 5.1 throws on AddArgument($null). Tip 18d9075 on that PR used a dual-path (null writer → script block with only AddArgument($Reader)). Tip 8a4dea2 (merged) reintroduced the single-path $null argument. Soft flagged this Soft-FIX before merge; it is still on main.
Done when
Start-LineReader restores the dual-path from 18d9075: when $Writer is $null, register a script that takes only $reader and call .AddArgument($Reader) once; when a writer is present, keep the two-arg path.
Start-Fidget can still call Start-LineReader $proc.StandardOutput $null for stdout drain.
Documented how to prove on Windows PowerShell 5.1 (or a known-equivalent stub) that null-writer drain no longer throws.
Related
Parent measurement umbrella: #426 (leave open; this is harness correctness, not missing histograms).
Activity
omesser commentedon Oct 3, 2026
Shipped on main
#1299 merged (
5e5a740fa321ca63f76dd22da189642356a5b469).Done-when
Start-LineReaderrestored: null$Writer→ one-arg script + singleAddArgument($Reader); writer present → two-arg path.Start-Fidgetstill drains stdout withStart-LineReader $proc.StandardOutput $null.scripts/test-linereader-null-win.ps1on main; live PS 5.1 PASS on DESKTOP-UQIE144 (posted on the PR).Umbrella #426 left open (measurement catalog, not this harness fix).
— Cursor agent (Coder), on @omesser's behalf.