Skip to content

fix(overlay): Windows cadence bench Start-LineReader must not AddArgument($null) #1269

Closed

Description

@omesser

Bug

scripts/bench-frame-cadence-windows.ps1 on main (from #1263 merge 241c033ac2ec) drains stdout with:

$script:OutDrain = Start-LineReader $proc.StandardOutput $null

and Start-LineReader always does:

}).AddArgument($Reader).AddArgument($Writer)

Windows PowerShell 5.1 throws on AddArgument($null). Tip 18d9075 on that PR used a dual-path (null writer → script block with only AddArgument($Reader)). Tip 8a4dea2 (merged) reintroduced the single-path $null argument. Soft flagged this Soft-FIX before merge; it is still on main.

Done when

  • Start-LineReader restores the dual-path from 18d9075: when $Writer is $null, register a script that takes only $reader and call .AddArgument($Reader) once; when a writer is present, keep the two-arg path.
  • Start-Fidget can still call Start-LineReader $proc.StandardOutput $null for stdout drain.
  • Documented how to prove on Windows PowerShell 5.1 (or a known-equivalent stub) that null-writer drain no longer throws.

Related

  • Parent measurement umbrella: #426 (leave open; this is harness correctness, not missing histograms).
  • Soft Open Soft-FIX on #1263.

— Cursor agent (Coder), on @omesser's behalf.

Activity

  1. added
    bugSomething isn't working
    windowsRun the Windows compile job on this pull request
    performanceCPU/GPU/memory/idle cost and benchmarking
    on Oct 2, 2026
  2. added this to the V1 milestone on Oct 2, 2026
  3. moved this from Todo to In Progress in Fidgeton Oct 3, 2026
  4. moved this from In Progress to Done in Fidgeton Oct 3, 2026
  5. omesser commented on Oct 3, 2026

    @omesser
    OwnerAuthor

    Shipped on main

    #1299 merged (5e5a740fa321ca63f76dd22da189642356a5b469).

    Done-when

    • Dual-path Start-LineReader restored: null $Writer → one-arg script + single AddArgument($Reader); writer present → two-arg path.
    • Start-Fidget still drains stdout with Start-LineReader $proc.StandardOutput $null.
    • Proof: scripts/test-linereader-null-win.ps1 on main; live PS 5.1 PASS on DESKTOP-UQIE144 (posted on the PR).

    Umbrella #426 left open (measurement catalog, not this harness fix).

    — Cursor agent (Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingperformanceCPU/GPU/memory/idle cost and benchmarkingwindowsRun the Windows compile job on this pull request

    Projects

    • Status
      Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions