Skip to content

chat-close-pill-type: Escape does not close the pill on macOS #1644

Closed

Description

@omesser

Problem

On macOS, scripts/scenarios/chat-close-pill-type.sh fails at its escape step on main (built at 5088c5c):

ok: escape: the pill took "seven" with no click
FAIL: escape: the pill did not close; see .../process.log

Expected: Escape in an open pill closes it and hands the keyboard back. #1566 added this path: keydown in src/quick-message.js calls dismissOpen on Escape, and the scenario asserts the matching overlay: draft ... closed line.

Actual: the last line in process.log is overlay: draft instance=... text="seven" focused=true. No closed line and no hand back line follow, so the key either never reached the field or was refused.

I hit this 3 times out of 3, on main and on #1641 alike. Step 1 needs #1643 to get that far reliably.

docs/design/cues.html still says "Escape does not dismiss". That text comes from #1078, which predates #1566.

Done when

  • Find out whether Escape reaches the pill's field when the scenario's ax key <pid> escape sends it.
  • The scenario's escape step passes on macOS, or the step changes to match whichever behavior is decided.

🤖 Generated with Claude Code

— Claude Code agent, on @omesser's behalf.

Activity

  1. added
    bugSomething isn't working
    needs-triageMaintainer needs to evaluate this issue
    p2Eventually: real, but nothing waits on it
    macosmacos / OSX specific
    on Oct 18, 2026
  2. added this to the V1 milestone on Oct 18, 2026
  3. omesser commented on Oct 19, 2026

    @omesser
    OwnerAuthor

    Status after #1643: #1643 is merged, so step 1 of the macOS leaf now waits for the Character to land before its first click. Its PR body shows step 1 passing on macOS and the run reaching escape, where it still fails as described here. Nothing proves the macOS escape step works yet, so this issue stays open.

    • X11: chat-close-pill-type.x11.sh passed 3 of 3 live runs on Linux at 4a5b44b0, including ok: escape: the pill took "seven" with no click and ok: escape: typing went back to the editor. Escape closes the pill and hands the keyboard back on X11, so this failure looks specific to macOS or to how ax key <pid> escape delivers the key.

    — Cursor agent (Architect), on @omesser's behalf.

  4. omesser commented on Oct 19, 2026

    @omesser
    OwnerAuthor

    Decided: Escape closes the pill, as #1566 built it. docs/design/cues.html ("Escape does not dismiss", from #1078) is out of date and changes with the fix.

    🤖 Generated with Claude Code

    — Claude Code agent, on @omesser's behalf.

  5. added
    ready-for-agentFully specified, ready for an AFK agent
    and removed
    needs-triageMaintainer needs to evaluate this issue
    on Oct 19, 2026
  6. moved this from Todo to In Progress in Fidgeton Oct 19, 2026
  7. moved this from In Progress to Done in Fidgeton Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingmacosmacos / OSX specificp2Eventually: real, but nothing waits on itready-for-agentFully specified, ready for an AFK agent

    Projects

    • Status
      Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions