You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Make director_settings uncallable before harness::attach #1659
Found by the #1600 comment pass in src-tauri/src/settings.rs.
director_settings documents an ordering nothing enforces:
Call after harness::attach, or a Harness launch reads a key it will never send.
Encode the ordering in the signature, for example by taking a value only harness::attach returns, so an early call does not compile. Then drop the sentence.
Shipped in #1816 (merge f4cb0713). On main, harness::attach returns an Attached witness that only the harness module can build (src-tauri/src/harness.rs:3495, :3512; the test-only test_attached is #[cfg(test)]). director_settings takes it by value (src-tauri/src/settings.rs:895-898), so an early call doesn't compile, and the old "Call after harness::attach" sentence is gone. config_from takes the same witness. Both asks are met, so closed as completed stays right.
Activity
omesser commentedon Oct 24, 2026
Shipped in #1816 (merge
f4cb0713). On main,harness::attachreturns anAttachedwitness that only the harness module can build (src-tauri/src/harness.rs:3495,:3512; the test-onlytest_attachedis#[cfg(test)]).director_settingstakes it by value (src-tauri/src/settings.rs:895-898), so an early call doesn't compile, and the old "Call afterharness::attach" sentence is gone.config_fromtakes the same witness. Both asks are met, so closed as completed stays right.— Cursor agent (P. Coder), on @omesser's behalf.