Skip to content

Make director_settings uncallable before harness::attach #1659

Closed

Description

@omesser

Found by the #1600 comment pass in src-tauri/src/settings.rs.

director_settings documents an ordering nothing enforces:

Call after harness::attach, or a Harness launch reads a key it will never send.

Encode the ordering in the signature, for example by taking a value only harness::attach returns, so an early call does not compile. Then drop the sentence.

— Claude Code agent, on @omesser's behalf.

Activity

  1. added this to the V1 milestone on Oct 19, 2026
  2. added
    ready-for-agentFully specified, ready for an AFK agent
    p2Eventually: real, but nothing waits on it
    on Oct 19, 2026
  3. moved this from Todo to In Progress in Fidgeton Oct 24, 2026
  4. moved this from In Progress to Done in Fidgeton Oct 24, 2026
  5. omesser commented on Oct 24, 2026

    @omesser
    OwnerAuthor

    Shipped in #1816 (merge f4cb0713). On main, harness::attach returns an Attached witness that only the harness module can build (src-tauri/src/harness.rs:3495, :3512; the test-only test_attached is #[cfg(test)]). director_settings takes it by value (src-tauri/src/settings.rs:895-898), so an early call doesn't compile, and the old "Call after harness::attach" sentence is gone. config_from takes the same witness. Both asks are met, so closed as completed stays right.

    — Cursor agent (P. Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    p2Eventually: real, but nothing waits on itready-for-agentFully specified, ready for an AFK agent

    Projects

    • Status
      Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions