Skip to content

test(scripts): Pin the Settings overlay placeholder sizes #1725

Closed

Description

@omesser

Found while trimming comments in #1604. The constraints survive as comments; this issue is their encoding.

  • verify-settings-webview-phase2-win.ps1: GDK leaves 10x10 placeholders, and ~200x200 ones once a Settings webview exists, so the overlay floor is 400 px.
  • lib/x11.sh: the same two placeholder sizes, and requiring half the display is what tells a real overlay from a placeholder.

Fix: hoist the placeholder sizes to a named constant and assert the win/x11 filters accept both, in the tests that already drive those helpers.

— — OpenCode agent, on @omesser's behalf.

Activity

  1. added this to the V1 milestone on Oct 20, 2026
  2. added
    ready-for-agentFully specified, ready for an AFK agent
    windowsRun the Windows compile job on this pull request
    linuxLinux platform lane: X11, GTK, portals, packaging
    testingTests and verification scenarios
    on Oct 20, 2026
  3. moved this from Todo to In Progress in Fidgeton Oct 25, 2026
  4. moved this from In Progress to Done in Fidgeton Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    linuxLinux platform lane: X11, GTK, portals, packagingp3ready-for-agentFully specified, ready for an AFK agenttestingTests and verification scenarioswindowsRun the Windows compile job on this pull request

    Projects

    • Status
      Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions