You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Open Memory through the platform seam, not macOS open(1) #195
open is macOS. Linux needs xdg-open; Windows needs cmd /c start (or start via cmd). Today a Linux user who can open settings at all still cannot open Memory from either entry point.
platform.rs already exists so that adding a platform is one edit in one file. Opening a user-owned file is the same kind of question as show_settings: the Shell asks, the OS answers. Two copies of the macOS answer in main and settings are how the next platform misses one.
Delete both open_in_editor functions. One platform::open_path(&Path) -> Result<(), String> remains.
macOS: open. Linux: xdg-open. Windows: cmd /C start "" (empty title so a path with spaces is not eaten as the window title).
Keep the ensure-parent-and-empty-file behaviour. That is not platform-specific; it can sit next to the call or inside it.
SettingsSession::open_memory and the Menu OpenMemory arm both call the seam.
tauri-plugin-opener is an alternative if it is already a cheap dependency. Do not add it only to wrap three Command::new lines. The platform module is the existing seam.
Acceptance
open appears once, behind cfg(target_os = "macos").
Linux cfg uses xdg-open. Windows cfg uses start via cmd.
Menu Open Memory and settings Open share that function. A platform that forgets one of them cannot compile a second copy.
A missing Memory file is still created empty before the opener runs.
Out of scope
The settings window on Linux/Windows. Changing where Memory lives. Wipe. Launch at login.
SettingsSession::open_memory now picks xdg-open on Linux (settings.rs), which is what #196 allowed while this issue was still open. The platform seam is not done: main.rs still has a second open_in_editor that always runs open, so Menu → Open Memory on Linux is still the macOS binary. No platform::open_path.
Both open_in_editor copies are gone. One platform::open_path remains: ensure_file then open / xdg-open / cmd /C start "". Menu Open Memory and SettingsSession::open_memory (GTK included) share it. Missing Memory is created empty first. Ubuntu + macOS CI were green.
Acceptance is met. Leftovers already tracked, not this ticket:
Activity
omesser commentedon Sep 3, 2026
#249 did not close this.
SettingsSession::open_memorynow picksxdg-openon Linux (settings.rs), which is what #196 allowed while this issue was still open. The platform seam is not done:main.rsstill has a secondopen_in_editorthat always runsopen, so Menu → Open Memory on Linux is still the macOS binary. Noplatform::open_path.Leave this open.
omesser commentedon Sep 3, 2026
Landed in #253 (
2a8299a).Both
open_in_editorcopies are gone. Oneplatform::open_pathremains:ensure_filethenopen/xdg-open/cmd /C start "". Menu Open Memory andSettingsSession::open_memory(GTK included) share it. Missing Memory is created empty first. Ubuntu + macOS CI were green.Acceptance is met. Leftovers already tracked, not this ticket:
cmd.exemetacharacters (&/^/%) /CommandExt::raw_arg: called out on ci: Compile the Windows arm, on the pull requests that can break it #247 as its own follow-up, out of scope there too