You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(shell): A saved Director key still costs a Keychain read at every launch #290
Follow-up to the review on fix/keychain-prompt-per-launch, which skipped the
startup read only for the case where the answer is provably elsewhere: an
exported AI_BUDDY_DIRECTOR_API_KEY. The user who saved a key through
Settings — the common case — still pays a launch-time Keychain read, and on an
unsigned build that read is two dialogs (#283).
Why it was not simply made lazy
configured is derived from whether a key exists, and it is decided once:
Nothing re-resolves. Skipping the read while the Director is off would report configured = false, and Toggle Director would then be unable to turn it on —
a worse bug than the prompt. retarget_payload is the one path that does
re-resolve, and it runs on the settings thread by design.
What a real fix needs
Either a frame-to-settings request so Toggle Director can re-resolve on demand,
or an Endpoint that holds a key provider rather than a String, so the read
happens on the first wake that needs it and never on a launch that does not.
The second also covers the Director being on but never woken.
Adjacent, same shape: key_status_for_view → stored_key_status reads the
store unconditionally when the settings window opens, including when the env
owns the key and the field is already frozen and unusable (#272). Whether the
window should still show the fingerprint of a key the env has overridden is a
UI question worth settling before changing it.
Activity
fix(shell): Skip the Keychain read when a Harness is the Completer