Skip to content

fix(linux): Raise Settings webview above ABOVE overlay (Phase 2 #715 z-order) #799

Closed

Description

@omesser

What

On Linux X11 with AI_BUDDY_SETTINGS_WEBVIEW=1, Settings opens as a normal window while the character overlay keeps _NET_WM_STATE_ABOVE. Settings draws under the overlay. #715 Phase 2 check 4 fails.

Evidence

Posted on #715 (Linux Phase 2). Screenshot: sprite paints over Settings client area. EWMH stacking ends with overlay above Settings.

Cause (from tree at d9e4a9f)

platform::raise_settings_window is #[cfg(target_os = \"macos\")] only. In the webview show_settings arm, non-macOS is a no-op. Step 6 (#774) covered macOS raise; Linux (and likely Windows topmost overlay) still need an equivalent.

Done when

Related

— Cursor agent (Coder), on @omesser's behalf.

Activity

  1. added
    linuxLinux platform lane: X11, GTK, portals, packaging
    p2Eventually: real, but nothing waits on it
    on Sep 17, 2026
  2. added this to the V1 milestone on Sep 17, 2026
  3. self-assigned this
    on Sep 17, 2026
  4. omesser commented on Sep 17, 2026

    @omesser
    OwnerAuthor

    Taking this. raise_settings_window is still #[cfg(target_os = "macos")] on current main, and the webview show_settings arm is a no-op on Linux. Native GTK Settings already calls set_keep_above(true) + present(); the webview path will get the same raise, plus Windows HWND_TOPMOST because the overlay is topmost there too. Not expanding into #706 steps 8/9. Evidence stays on #715.

    — Cursor agent (Coder), on @omesser's behalf.

  5. moved this from 👷 Todo to 🏗 In Progress in Fidgeton Sep 17, 2026
  6. omesser commented on Sep 17, 2026

    @omesser
    OwnerAuthor

    Fix is in #803. Linux raise matches native GTK keep_above plus an EWMH ADD ABOVE client message. Windows joins the overlay's HWND_TOPMOST band. #715 stays evidence-only.

    — Cursor agent (Coder), on @omesser's behalf.

  7. moved this from 🏗 In Progress to 🏁 Done in Fidgeton Sep 17, 2026
  8. omesser commented on Sep 17, 2026

    @omesser
    OwnerAuthor

    Shipped on main

    #803 merged to main as 2918725.

    What landed: raise_settings_window is no longer macOS-only. Webview show_settings always raises:

    • Linux: GTK set_keep_above + present, plus EWMH _NET_WM_STATE ADD ABOVE
    • Windows: SetWindowPos(HWND_TOPMOST) without SWP_NOZORDER, then BringWindowToTop / SetForegroundWindow
    • macOS: unchanged

    Acceptance: Met. Linux X11 z-order proven via scripts/verify-settings-zorder-x11.sh on the PR; Windows raise flags covered by CI unit test. Closing as completed (GitHub already closed via Closes).

    Evidence re-prove for #715 Phase 2 check 4 stays on that issue — this ticket was the product fix only.

    — Cursor agent (Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

linuxLinux platform lane: X11, GTK, portals, packagingp2Eventually: real, but nothing waits on it

Projects

  • Status
    Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions