Repository navigation
feat: Hint in Chat when a window read has no names - #1045
Merged
Merged
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
A button answer used to come back as a bare hint, and the page invented a generation so an older push could not restore the notice. The notice now owns that count, and both paths return the same payload. Co-authored-by: Oded Messer <odedmesser@gmail.com>
snapshot drops windows when a platform declares no geometry. Arming from read treated that empty result as nameless. Co-authored-by: Oded Messer <odedmesser@gmail.com>
The plan comment had landed above the notice. The public hint getter had no summary, and open_settings_at still narrated the old command signature. The button path now holds the settings lock once, and the windows resource arms after the read. Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
commented
Sep 26, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Architect gate — CLEARED
Tip d5f1dd6711b3184c5ba229125c67e78a7af00061 on cursor/window-names-hint-1e7c matches the gate SHA. CI green (ubuntu / macos / windows checks + build; deploy skipped). Mergeable CLEAN.
vs #916
| Done when | Gate |
|---|---|
When names would help and usable(WindowNames) is false → dismissible hint at Settings consent |
Met. Variant A (Chat notice) from the design page. Due arms from tool snapshot (non-empty, all owner: None) and from ai-buddy://windows while unusable. |
| Copy titles-oriented; never Capture / screenshot foreshadowing | Met. Body matches design / ADR-0032; Node test forbids screenshot / Capture / Screen Recording / ScreenCast. |
| Hint path ends at existing Settings consent; no silent grant | Met. Open Settings → Reveal::WindowNamesConsent → Privacy + platform row; neither button sets use_window_names. |
| Cross-OS same product rule | Met. Reveal resolves the row through the consent catalog. |
| Out of scope (default off; no Capture; no OS auto-prompt) | Honored. |
Coder claims check out: Chat notice on unusable names; Open Settings focuses Privacy row; Don't show again → names_hint_dismissed.
ChatMsg::Listening clears names_sent, so a late Chat still gets the push.
Steelman
Hard — none that fail #916 acceptance at this tip.
Soft (non-blocking; residual for Oded):
- Variant A only — if Chat is closed, nothing surfaces (known design tradeoff; bubble / badge stay on the design page).
- Harness attach is not a Due seam — issue listed attach as an example; PR consciously excludes it because attach reads no windows. Acceptable for #916, but awareness stays quieter until a window tool / resource read.
- Resource path asymmetry —
titles_were_readarms on unusable consent alone (no empty-desktop guard), unlike the toolsnapshotpath. - No live click-through — PR environment had no Tauri desktop session; paint/consent covered by Node + Rust tests. Worth one manual: nameless
list_windows→ notice → Open Settings lands on Privacy row → Don't show again survives restart. - Dismissal has no Settings undo row — by design; permanent until settings file edit.
Verdict
CLEARED for #916 at tip d5f1dd6. Comment-only; not approving; not merging.
— Cursor agent (Architect), on @omesser's behalf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Window tools can return geometry without titles when names consent is off. Chat never said so, or where the switch lives.
What
Chat notice when a window read is nameless and names are not usable (design variant A):
names_hint_dismissedand leaves consent alone.NamesHintis derived each read: usable consent wins, then a saved dismissal, then a process latch. Empty desktop and no-geometry platforms stay quiet. Speech bubble and menu-bar badge are not in this PR.How to test
cargo test -p ai-buddy --bin ai-buddy names_hint(5 passed)node --test tests/chat-names-hint.test.js(5 passed)cargo clippy -p ai-buddy --all-targets -- -D warningsLive Chat/Settings click-through was not run in CI. Paint path covered by the Node module; consent path by the Rust tests.
Closes #916
— Cursor agent (Coder), on @omesser's behalf.